On Wed, May 22, 2024 at 6:21 PM Caleb Connolly
<caleb.conno...@linaro.org> wrote:
>
> Hi Robert,
>
> Thanks for the patches.
>
> On 22/05/2024 12:13, Robert Marko wrote:
> > IPQ4019 ESS EDMA support is not yet in upstream Linux, and even when
> > eventually it is merged the node will not be compatible with U-Boot driver
> > as the Linux driver properly models the internal switch.
>
> Is this going to cause dtc compile errors when the node eventually does
> land upstream and gets pulled into U-Boot?
Yes, most likely the nodes will conflict.
>
> How hard would it be to adjust the U-Boot driver to work with the
> upstream bindings?
I can probably make it work with the current latest pending Linux node plus some
minor U-Boot additions, I don't think the node will change much (If at
all) in newer Linux
patch series for the IPQESS driver.
Regards,
Robert
>
> Kind regards,
> >
> > So, lets add the U-Boot additions DTSI for ESS EDMA for now.
> >
> > Signed-off-by: Robert Marko <robert.ma...@sartura.hr>
> > ---
> > arch/arm/dts/qcom-ipq4019-u-boot.dtsi | 27 +++++++++++++++++++++++++++
> > 1 file changed, 27 insertions(+)
> > create mode 100644 arch/arm/dts/qcom-ipq4019-u-boot.dtsi
> >
> > diff --git a/arch/arm/dts/qcom-ipq4019-u-boot.dtsi
> > b/arch/arm/dts/qcom-ipq4019-u-boot.dtsi
> > new file mode 100644
> > index 0000000000..f70ef5c9a5
> > --- /dev/null
> > +++ b/arch/arm/dts/qcom-ipq4019-u-boot.dtsi
> > @@ -0,0 +1,27 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> > +/ {
> > + soc {
> > + edma: edma@c080000 {
> > + compatible = "qcom,ess-edma";
> > + reg = <0xc080000 0x8000>, <0x98000 0x800>, <0xc000000
> > 0x80000>;
> > + reg-names = "edma", "psgmii_phy", "switch";
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + resets = <&gcc ESS_PSGMII_ARES>, <&gcc ESS_RESET>;
> > + reset-names = "psgmii", "ess";
> > + clocks = <&gcc GCC_ESS_CLK>;
> > + clock-names = "ess";
> > + status = "disabled";
> > +
> > + switch_ports: switch-ports {
> > + phy-mode = "psgmii";
> > + };
> > + };
> > + };
> > +};
> > +
> > +&mdio {
> > + psgmiiphy: psgmii-phy@5 {
> > + reg = <5>;
> > + };
> > +};
>
> --
> // Caleb (they/them)
--
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.ma...@sartura.hr
Web: www.sartura.hr
