On 2024-06-18 12:04, Dragan Simic wrote:
On 2024-06-18 11:58, Heinrich Schuchardt wrote:
The message 'No working controllers found' provides no clue that this
refers to USB controllers.
Provide a message that refers to USB. Use log_info().
Huh, I missed the "use log_info()" part. The patch description should
be adjusted not to mention it, and there should be another patch that
switches printf() to log_info().
Signed-off-by: Heinrich Schuchardt <heinrich.schucha...@canonical.com>
Thanks for rerolling this patch. Looking good to me.
Reviewed-by: Dragan Simic <dsi...@manjaro.org>
---
v3:
plural controllers
v2:
add 'found' at end of message
keep printf
---
drivers/usb/host/usb-uclass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/usb-uclass.c
b/drivers/usb/host/usb-uclass.c
index a1cd0ad2d66..e16432a1516 100644
--- a/drivers/usb/host/usb-uclass.c
+++ b/drivers/usb/host/usb-uclass.c
@@ -388,7 +388,7 @@ int usb_init(void)
/* if we were not able to find at least one working bus, bail out */
if (controllers_initialized == 0)
- printf("No working controllers found\n");
+ printf("No USB controllers found\n");
return usb_started ? 0 : -ENOENT;
}
