On Wed, Jun 19, 2024 at 08:15:04AM +0200, Michal Simek wrote: > út 18. 6. 2024 v 19:45 odesílatel Tom Rini <tr...@konsulko.com> napsal: > > > > After adding the U_BOOT_LONGHELP macro some new commands came in still > > that were not making use if it. Switch these cases over and in a few > > places add missing newlines as well. > > > > Signed-off-by: Tom Rini <tr...@konsulko.com> > > --- > > arch/arm/mach-imx/cmd_dek.c | 4 ++-- > > arch/arm/mach-imx/cmd_mfgprot.c | 4 ++-- > > arch/arm/mach-imx/imx8/snvs_security_sc.c | 16 ++++++++-------- > > arch/arm/mach-stm32mp/cmd_stm32key.c | 4 ++-- > > board/freescale/common/cmd_esbc_validate.c | 4 ++-- > > board/kontron/sl28/cmds.c | 4 ++-- > > cmd/adc.c | 4 ++-- > > cmd/arm/exception.c | 5 ++--- > > cmd/arm/exception64.c | 5 ++--- > > cmd/blob.c | 4 ++-- > > cmd/riscv/exception.c | 5 ++--- > > cmd/scmi.c | 5 ++--- > > cmd/x86/exception.c | 5 ++--- > > 13 files changed, 32 insertions(+), 37 deletions(-) [snip] > arch/arm/mach-imx/imx8/snvs_security_sc.c:781:static char > snvs_sec_status_help_text[] =
I missed this one for some reason, yeah. > board/xilinx/versal-net/cmds.c:74:static char versalnet_help_text[] = > > These two should also be part of this patch. OK. > And this one is interesting. > cmd/cli.c:122:static char cli_help_text[] = > > it is guarded by SYS_LONGHELP but I think it should be just removed > and macro should be used instead. > > #if CONFIG_IS_ENABLED(SYS_LONGHELP) > static char cli_help_text[] = > "get - print current cli\n" > "set - set the current cli, possible value are: old, modern" > ; > #endif > > U_BOOT_CMD(cli, 3, 1, do_cli, > "cli", > #if CONFIG_IS_ENABLED(SYS_LONGHELP) > cli_help_text > #endif > ); This one is actually kind of "funny". I know I changed it to that, rather than using the macro like everything else, when I first did the conversion as there was some sort of odd build failure introduced. I'll go and see if it still fails somewhere. -- Tom
signature.asc
Description: PGP signature
