On 10:26-20240618, Dhruva Gole wrote: > Add support for packaging the TIFS Stub as it's required for basic Low > Power Modes like Deep Sleep.
What the heck is tifs stub? https://docs.u-boot.org/en/latest/search.html?q=tifs&check_keywords=yes&area=default I see no mention of the same? > > Acked-by: Neha Malcom Francis <n-fran...@ti.com> > Signed-off-by: Dhruva Gole <d-g...@ti.com> > --- > > No changes from v1, just picked Neha's ack and rebased on master again. > Link to v1: > https://lore.kernel.org/u-boot/20240612062351.3690091-1-d-g...@ti.com/ > > arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 33 +++++++++++++++++++- > 1 file changed, 32 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi > b/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi > index fb2032068d1c..5e2248a4a668 100644 > --- a/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi > +++ b/arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi > @@ -69,6 +69,23 @@ > }; > }; > > + tifsstub-gp { > + filename = "tifsstub.bin_gp"; > + ti-secure-rom { > + content = <&tifsstub_gp>; > + core = "secure"; > + load = <0x60000>; > + sw-rev = <CONFIG_K3_X509_SWRV>; > + keyfile = "ti-degenerate-key.pem"; > + tifsstub; > + }; > + tifsstub_gp: tifsstub-gp.bin { > + filename = "ti-sysfw/ti-fs-stub-firmware-am62x-gp.bin"; > + type = "blob-ext"; > + optional; > + }; > + }; > + > ti-spl_unsigned { > filename = "tispl.bin_unsigned"; > pad-byte = <0xff>; > @@ -105,6 +122,19 @@ > }; > }; > > + tifsstub-gp { > + description = "tifsstub"; > + type = "firmware"; > + arch = "arm32"; > + compression = "none"; > + os = "tifsstub-gp"; > + load = <0x9dc00000>; > + entry = <0x9dc00000>; two issues with this: a) if the tifsstub-gp is not automatically consumed by tifs by the time u-boot is up or kernel is up, this is going to get clobbered by OS https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts#n78 Should be updated before this is done. b) Documentation update - please always make sure you update documentation when doing this kind of change https://docs.u-boot.org/en/latest/board/beagle/am62x_beagleplay.html#image-formats > + blob-ext { > + filename = "tifsstub.bin_gp"; > + }; > + }; > + > dm { > description = "DM binary"; > type = "firmware"; > @@ -148,7 +178,8 @@ > conf-0 { > description = "k3-am625-beagleplay"; > firmware = "atf"; > - loadables = "tee", "dm", "spl"; > + loadables = "tee", "dm", "spl", > + "tifsstub-gp"; > fdt = "fdt-0"; > }; > }; > > base-commit: 16324b43db3f2b4fbbc3b701893fcfc4104f33fb > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
