Hi Ilias,
On Sun, 23 Jun 2024 at 05:48, Ilias Apalodimas
<ilias.apalodi...@linaro.org> wrote:
>
> We currently return 'No space left on device' if the eventlong buffer
> we allocated is not enough. On a similar check later on that function
> during the call to tcg2_log_init() we return 'No buffer space
> available'. So switch both error codes to -ENOBUFS since we are always
> checking a buffer and not a device.
>
> Fixes: commit 97707f12fdab ("tpm: Support boot measurements")
> Reviewed-by: Heinrich Schuchardt <xypron.g...@gmx.de>
> Signed-off-by: Ilias Apalodimas <ilias.apalodi...@linaro.org>
> ---
> lib/tpm-v2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Simon Glass <s...@chromium.org>
For better or worse, we mostly use -ENOSPC for this sort of thing. But
this will at least make the TPM error stand out.
>
> diff --git a/lib/tpm-v2.c b/lib/tpm-v2.c
> index a67daed2f3c1..91526af33acb 100644
> --- a/lib/tpm-v2.c
> +++ b/lib/tpm-v2.c
> @@ -554,7 +554,7 @@ int tcg2_log_prepare_buffer(struct udevice *dev, struct
> tcg2_event_log *elog,
> if (elog->log_size) {
> if (log.found) {
> if (elog->log_size < log.log_position)
> - return -ENOSPC;
> + return -ENOBUFS;
>
> /*
> * Copy the discovered log into the user
> buffer
> --
> 2.45.2
>
Regards,
Simon
