Set pcie-phy optional for PCIe gen3. MT7988 doesn't require it and
making it mandatory prevent the driver to correctly probe.

Signed-off-by: Christian Marangi <ansuels...@gmail.com>
---
 drivers/pci/pcie_mediatek_gen3.c | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/drivers/pci/pcie_mediatek_gen3.c b/drivers/pci/pcie_mediatek_gen3.c
index 673813b8b75..0149edae0bf 100644
--- a/drivers/pci/pcie_mediatek_gen3.c
+++ b/drivers/pci/pcie_mediatek_gen3.c
@@ -284,9 +284,8 @@ static int mtk_pcie_power_on(struct udevice *dev)
 
        pcie->priv = dev;
 
-       err = generic_phy_get_by_name(dev, "pcie-phy", &pcie->phy);
-       if (err)
-               return err;
+       /* pcie-phy is optional (mt7988 doesn't need it) */
+       generic_phy_get_by_name(dev, "pcie-phy", &pcie->phy);
 
        /*
         * Upstream linux kernel devine these clock without clock-names
@@ -308,13 +307,15 @@ static int mtk_pcie_power_on(struct udevice *dev)
        if (err)
                return err;
 
-       err = generic_phy_init(&pcie->phy);
-       if (err)
-               return err;
+       if (pcie->phy.dev) {
+               err = generic_phy_init(&pcie->phy);
+               if (err)
+                       return err;
 
-       err = generic_phy_power_on(&pcie->phy);
-       if (err)
-               goto err_phy_on;
+               err = generic_phy_power_on(&pcie->phy);
+               if (err)
+                       goto err_phy_on;
+       }
 
        err = clk_enable(&pcie->pl_250m_ck);
        if (err)
@@ -348,7 +349,8 @@ err_clk_tl_26m:
 err_clk_pl_250m:
        clk_disable(&pcie->pl_250m_ck);
 err_phy_on:
-       generic_phy_exit(&pcie->phy);
+       if (pcie->phy.dev)
+               generic_phy_exit(&pcie->phy);
 
        return err;
 }
-- 
2.45.1

Reply via email to