Hi Mikhail, mikhail.kshevets...@iopsys.eu wrote on Thu, 27 Jun 2024 14:20:02 +0300:
A commit log would be welcome here as many things happen in this patch. I'm fine overall, I didn't thoroughly review all the patches but they look sensible to me. > Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevets...@iopsys.eu> > --- > drivers/mtd/nand/spi/core.c | 259 +++++++++++++++++++++--------------- > 1 file changed, 151 insertions(+), 108 deletions(-) > > diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c > index 8664e882753..1b2eefc9041 100644 > --- a/drivers/mtd/nand/spi/core.c > +++ b/drivers/mtd/nand/spi/core.c > @@ -156,20 +156,12 @@ int spinand_select_target(struct spinand_device > *spinand, unsigned int target) > return 0; > } > > -static int spinand_init_cfg_cache(struct spinand_device *spinand) > +static int spinand_read_cfg(struct spinand_device *spinand) > { > struct nand_device *nand = spinand_to_nand(spinand); > - struct udevice *dev = spinand->slave->dev; > unsigned int target; > int ret; > > - spinand->cfg_cache = devm_kzalloc(dev, > - sizeof(*spinand->cfg_cache) * > - nand->memorg.ntargets, > - GFP_KERNEL); ... Thanks, Miquèl