Hi,
On Fri, 17 May 2024 at 17:36, Jiaxun Yang <jiaxun.y...@flygoat.com> wrote:
>
>
>
> 在2024年5月17日五月 下午5:06，Heinrich Schuchardt写道：
> > Since commit a75cf70d23ac ("efi: Correct handling of frame buffer") the EFI
> > block image transfer is broken on the sandbox.
> >
> > To test build sandbox_defconfig with CONFIG_EFI_SELFTEST=y and execute
> >
> > setenv efi_selftest block image transfer
> > bootefi selftest
> >
> > Fixes: a75cf70d23ac ("efi: Correct handling of frame buffer")
> > Signed-off-by: Heinrich Schuchardt <heinrich.schucha...@canonical.com>
>
> Reviewed-by: Jiaxun Yang <jiaxun.y...@flygoat.com>
>
> It turns out that texture copy is only required for 8bpc display, which
> we don't care much anyway.
I can repeat this with this change in sandbox.dtsi in the /lcd node:
log2-depth = <3>;
I see:
>>>
Selected test: 'block image transfer'
Setting up 'block image transfer'
Graphical output protocol is not available.
Setting up 'block image transfer' succeeded
Executing 'block image transfer'
Executing 'block image transfer' succeeded
Tearing down 'block image transfer'
Tearing down 'block image transfer' succeeded
Summary: 0 failures
<<<
It looks like gop_get_bpp() doesn't have support for VIDEO_BPP8 and
there may be other problems.
I don't want to display this option in sandbox, since we want to test
the VIDEO_COPY feature. Instead, I think EFI support should be
enhanced to cover 8bpp if desired.
Regards,
Simon
