On Wed, Jul 10, 2024 at 06:26:17PM +0200, Caleb Connolly wrote: > U-Boot already emits frame pointers on ARM64, but lacks the code to > parse them, as well as a mechanism for looking up symbol names at > runtime. > > There was some (seemingly?) leftover code for symbols lookups in > common/kallsyms.c and associated parts in the makefile, however it > appears to be entirely unused and unsupported. It relied on generating > one long string of all symbol addresses and names. > > The approach taken here is instead largely based on the implementation > in the Xen hypervisor, it performs basic compression using non-ASCII > bytes to tokenize repeated string segments which can later be expanded > back out at runtime. > > This is then utilized in the ARM64 interrupt handling routine to dump a > backtrace in the show_regs() debug function. As well as providing a > general purpose unwind_stack() function which can be used for debugging.
Just a few minor comments from me in general, and I'm glad to see this. Please submit the next version non-RFC, thanks. -- Tom
signature.asc
Description: PGP signature
