On Apr 21, 2011, at 12:10 PM, Mike Frysinger wrote: > On Thu, Apr 21, 2011 at 2:04 AM, Shaohui Xie wrote: >> --- a/include/spi.h >> +++ b/include/spi.h >> /* Controller-specific definitions: */ >> >> /* CONFIG_HARD_SPI triggers SPI bus initialization in PowerPC */ >> -#ifdef CONFIG_MPC8XXX_SPI >> +#if defined(CONFIG_MPC8XXX_SPI) || defined(CONFIG_FSL_ESPI) >> # ifndef CONFIG_HARD_SPI >> # define CONFIG_HARD_SPI >> # endif > > i cant see why this PowerPC-specific code needs to be in the common > spi.h. why cant this live in a PowerPC header like asm/config.h ? (i > know this code predates asm/config.h) > -mike
If the rest of the patch looks fine we can move this into asm/config.h There are a bunch of board patches I'd like to get in that depend on the base SPI driver being in tree. - k _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
