On 09:33-20240717, Francesco Dolcini wrote: > Hello, > > On Wed, Jul 17, 2024 at 09:40:11AM +0530, Kumar, Udit wrote: > > On 7/17/2024 1:35 AM, Francesco Dolcini wrote: > > > On Mon, Jul 15, 2024 at 11:13:01PM +0530, Udit Kumar wrote: > > > > Increase malloc size to 32 MB to align with other J7 > > > > family devices. > > > Is this needed for any specific reason? I am asking to understand if > > > other boards using the same SOC should be updated to prevent > > > $random_issue. > > Since DFU is not supported yet in mainline u-boot, so I avoided to mention > > that failure. > > > > Also this change is generic, so i thought of pushing it now instead of > > waiting for DFU series. > > Thanks for the update, on our board DFU works fine on our j784s4 based > board (UUU or UMS are not working, but this is off topic for this > conversation ;-)
I still think your comment is valid - commit message does need to explain something like "make space for future standard features such as DFU etc.." -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D