Hi Simon,

> -----Original Message-----
> From: Simon Glass <s...@chromium.org>
> Sent: Friday, July 19, 2024 11:05 PM
> To: Z.Q. Hou <zhiqiang....@nxp.com>
> Cc: u-boot@lists.denx.de; sba...@denx.de; feste...@gmail.com;
> dl-uboot-imx <uboot-...@nxp.com>; tr...@konsulko.com; Peng Fan
> <peng....@nxp.com>; Tao Yang <tao.ya...@nxp.com>
> Subject: Re: [PATCHv1 1/3] mp: imx9: add cpu command support
> 
> Hi Zhiqiang,
> 
> On Fri, 19 Jul 2024 at 12:28, Zhiqiang Hou <zhiqiang....@nxp.com> wrote:
> >
> > From: Tao Yang <tao.ya...@nxp.com>
> >
> > Implement the cpu command to kick cpu core to run barematel or RTOS
> > applications.
> >
> > Signed-off-by: Tao Yang <tao.ya...@nxp.com>
> > Signed-off-by: Hou Zhiqiang <zhiqiang....@nxp.com>
> > ---
> >  arch/arm/mach-imx/imx9/Makefile |  4 +-
> >  arch/arm/mach-imx/imx9/mp.c     | 81
> +++++++++++++++++++++++++++++++++
> >  2 files changed, 84 insertions(+), 1 deletion(-)  create mode 100644
> > arch/arm/mach-imx/imx9/mp.c
> 
> This seems to be adding more code to a deprecated API. It should use
> UCLASS_CPU and driver model. See the comment at the top of cpu_func.h

Thanks for the guide! I saw the cmd/cpu.c provided a new 'cpu' command based on 
UCLASS_CPU, I'll add a 'release' subcommand.

Thanks,
Zhiqiang

Reply via email to