Hi Marek, Sorry for the review delay and thank you for the patch.
On jeu., juin 20, 2024 at 02:55, Marek Vasut <[email protected]> wrote: > From: Vitaliy Vasylskyy <[email protected]> > > Add UDC driver for Renesas USBHS controller found in R-Car Gen3 SoCs. > This is mostly ported from the Linux kernel, with additional porting > glue. The code has been synchronized with 1b4861e32e46 ("Linux 6.9.3") > and cleaned up and ported to DM since the original implementation by > Vitaliy. > > Signed-off-by: Vitaliy Vasylskyy <[email protected]> > Signed-off-by: Marek Vasut <[email protected]> > --- > Note that the driver does have a few checkpatch warnings in it, those > also partly come from Linux. > --- > Cc: Jonas Karlman <[email protected]> > Cc: Lukasz Majewski <[email protected]> > Cc: Mattijs Korpershoek <[email protected]> > Cc: Miquel Raynal <[email protected]> > Cc: Simon Glass <[email protected]> > Cc: Tom Rini <[email protected]> > Cc: Vitaliy Vasylskyy <[email protected]> I've reviewed this by comparing this patch to the Linux stable 6.9.3 codebase located in drivers/usb/renesas_usbhs/ and the phy driver (drivers/usb/renesas_usbhs/) While I notice some differences, such as: * no USB host support (no VBUS control support) * no dma mapping control support * no support for the older RCar controllers (rcar2) This looks good overall. Reviewed-by: Mattijs Korpershoek <[email protected]> [...] > --- > -- > 2.43.0
