Hi Patrick, On Sat, 27 Jul 2024 at 01:20, Patrick Rudolph <patrick.rudo...@9elements.com> wrote: > > Allows to build the RPi4 with ACPI enabled. > > TEST: - Boots on qemu-system-aarch64 -machine raspi4b > - Boots on real hardware with arm_64bit=1 in config.txt > > Signed-off-by: Patrick Rudolph <patrick.rudo...@9elements.com> > Cc: Simon Glass <s...@chromium.org> > Cc: Matthias Brugger <mbrug...@suse.com> > Cc: Peter Robinson <pbrobin...@gmail.com> > --- > configs/rpi_4_acpi_defconfig | 79 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 79 insertions(+) > create mode 100644 configs/rpi_4_acpi_defconfig
Can you please add some docs on this to doc/board/broadcom/raspberrypi.rst ? > > diff --git a/configs/rpi_4_acpi_defconfig b/configs/rpi_4_acpi_defconfig > new file mode 100644 > index 0000000000..cd80f46154 > --- /dev/null > +++ b/configs/rpi_4_acpi_defconfig > @@ -0,0 +1,79 @@ > +CONFIG_ARM=y > +CONFIG_ARCH_BCM283X=y > +CONFIG_TEXT_BASE=0x00080000 > +CONFIG_TARGET_RPI_4=y > +CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y > +CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x7fffe30 > +CONFIG_ENV_SIZE=0x4000 > +CONFIG_DEFAULT_DEVICE_TREE="bcm2711-rpi-4-b" > +CONFIG_OF_LIBFDT_OVERLAY=y > +CONFIG_DM_RESET=y > +CONFIG_SYS_LOAD_ADDR=0x1000000 > +CONFIG_PCI=y > +CONFIG_BOOTSTD_DEFAULTS=y > +CONFIG_OF_BOARD_SETUP=y > +CONFIG_FDT_SIMPLEFB=y > +CONFIG_USE_PREBOOT=y > +CONFIG_PREBOOT="pci enum; usb start;" > +CONFIG_SYS_PBSIZE=1049 > +# CONFIG_DISPLAY_CPUINFO is not set > +# CONFIG_DISPLAY_BOARDINFO is not set > +CONFIG_LAST_STAGE_INIT=y > +CONFIG_MISC_INIT_R=y > +CONFIG_SYS_PROMPT="U-Boot> " > +CONFIG_CMD_DFU=y > +CONFIG_CMD_GPIO=y > +CONFIG_CMD_MMC=y > +CONFIG_CMD_PCI=y > +CONFIG_CMD_USB=y > +CONFIG_CMD_FS_UUID=y > +CONFIG_ENV_FAT_DEVICE_AND_PART="0:1" > +CONFIG_SYS_RELOC_GD_ENV_ADDR=y > +CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y > +CONFIG_TFTP_TSIZE=y > +CONFIG_DM_DMA=y > +CONFIG_DFU_MMC=y > +CONFIG_SYS_DFU_DATA_BUF_SIZE=0x100000 > +CONFIG_SYS_DFU_MAX_FILE_SIZE=0x200000 > +CONFIG_BCM2835_GPIO=y > +CONFIG_MMC_SDHCI=y > +CONFIG_MMC_SDHCI_SDMA=y > +CONFIG_MMC_SDHCI_BCM2835=y > +CONFIG_BCMGENET=y > +CONFIG_PCI_BRCMSTB=y > +CONFIG_PINCTRL=y > +# CONFIG_PINCTRL_GENERIC is not set > +CONFIG_DM_RNG=y > +CONFIG_RNG_IPROC200=y > +# CONFIG_REQUIRE_SERIAL_CONSOLE is not set How come? > +CONFIG_SYSINFO=y > +CONFIG_SYSINFO_SMBIOS=y > +CONFIG_USB=y > +CONFIG_DM_USB_GADGET=y > +CONFIG_USB_XHCI_HCD=y > +CONFIG_USB_XHCI_PCI=y > +CONFIG_USB_KEYBOARD=y > +CONFIG_USB_GADGET=y > +CONFIG_USB_GADGET_MANUFACTURER="FSL" > +CONFIG_USB_GADGET_VENDOR_NUM=0x0525 > +CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 > +CONFIG_USB_GADGET_DWC2_OTG=y > +CONFIG_USB_GADGET_DOWNLOAD=y > +CONFIG_VIDEO=y > +# CONFIG_VIDEO_BPP8 is not set > +# CONFIG_VIDEO_BPP16 is not set > +CONFIG_SYS_WHITE_ON_BLACK=y > +CONFIG_VIDEO_BCM2835=y > +CONFIG_CONSOLE_SCROLL_LINES=10 > +CONFIG_PHYS_TO_BUS=y > +CONFIG_OF_LIBFDT_OVERLAY=y > + Please drop blank line > +CONFIG_GENERATE_ACPI_TABLE=y > +CONFIG_ACPI=y > +CONFIG_ACPI_PARKING_PROTOCOL=y > +CONFIG_CMD_ACPI=y > +CONFIG_BOOTM_EFI=y > +CONFIG_CMD_BOOTEFI=y > +CONFIG_EFI_VARIABLE_NO_STORE=y > +#CONFIG_EFI_RT_VOLATILE_STORE=y Should this have 'is not set' ? > +CONFIG_HEXDUMP=y > -- > 2.45.2 > It looks like the ordering is wrong above...so please check with 'make savedefconfig'. Regards, Simon
