Changing the duty-cycle should not blindly override (and clear) the
enable (EN) bit if it has already been set. For instance, a PWM
backlight can be enabled and set to a specific intensity using two
operations. The order of these operations should not matter.

Signed-off-by: Miquel Raynal <miquel.ray...@bootlin.com>
---
 drivers/pwm/pwm-imx.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index 8fbb40cc276..8bcc8f2af02 100644
--- a/drivers/pwm/pwm-imx.c
+++ b/drivers/pwm/pwm-imx.c
@@ -21,10 +21,11 @@ int pwm_config_internal(struct pwm_regs *pwm, unsigned long 
period_cycles,
        u32 cr;
 
        writel(0, &pwm->ir);
-       cr = PWMCR_PRESCALER(prescale) |
+
+       cr = readl(&pwm->cr) & PWMCR_EN;
+       cr |= PWMCR_PRESCALER(prescale) |
                PWMCR_DOZEEN | PWMCR_WAITEN |
                PWMCR_DBGEN | PWMCR_CLKSRC_IPG_HIGH;
-
        writel(cr, &pwm->cr);
        /* set duty cycles */
        writel(duty_cycles, &pwm->sar);
-- 
2.43.0

Reply via email to