> -----Original Message----- > From: Linus Walleij <linus.wall...@linaro.org> > Sent: Thursday, September 12, 2024 1:16 AM > To: William Zhang <william.zh...@broadcom.com> > Cc: u-boot@lists.denx.de; Dario Binacchi > <dario.binac...@amarulasolutions.com>; Michael Trimarchi > <mich...@amarulasolutions.com>; Anand Gore > <anand.g...@broadcom.com>; Kursad Oney > <kursad.o...@broadcom.com>; Philippe Reynes > <philippe.rey...@softathome.com>; Florian Fainelli > <florian.faine...@broadcom.com>; Miquel Raynal > <miquel.ray...@bootlin.com>; Kamal Dasu <kamal.d...@broadcom.com>; > David Regan <dre...@broadcom.com> > Subject: Re: [PATCH 0/7] mtd: nand: brcmnand: Backported fixes from > Linux > > On Thu, Sep 12, 2024 at 3:32 AM William Zhang > <william.zh...@broadcom.com> wrote: > > > Thanks for merging the patches to u-boot. We actually had something > > similar > > here locally but just didn't get the chance to upstream yet. > > > > We will review and compare your patches to ours and get back to you. > > Ah, excellent, I guess you guys know the stuff better than me > so I prefer if your patches are used. > > Do you even have U-Boot working on BCMBCA? I didn't get the > NAND to detect properly yet despite all the backported patches. :/ > Yes we have it working. And your patches works too after fixing two Issues that I will comment on the specific patch. You will need to enable the NAND related configurations and the nand dts node.
You can use existing dts node to set the specific ecc level, oob size and ecc step size. Or use the new automatically detection from the strap property brcm,nand-ecc-use-strap that I upstreamed to linux. What SoC do you use? > Yours, > Linus Walleij
smime.p7s
Description: S/MIME Cryptographic Signature
