Hi Marek,
On 2024-09-25 04:21, Marek Vasut wrote:
> In case a regulator DT node contains regulator-always-on or regulator-boot-on
> property, make sure the regulator gets correctly configured by U-Boot on start
> up. Unconditionally probe such regulator drivers. This is a preparatory patch
> for introduction of .regulator_post_probe() which would trigger the regulator
> configuration.
>
> Parsing of regulator-always-on and regulator-boot-on DT property has been
> moved to regulator_post_bind() as the information is required early, the
> rest of the DT parsing has been kept in regulator_pre_probe() to avoid
> slowing down the boot process.
>
> Signed-off-by: Marek Vasut <ma...@denx.de>
[snip]
>
> - debug("'%s' of dev: '%s', has nonunique value: '%s\n",
> - property, dev->name, uc_pdata->name);
> + /*
> + * In case the regulator has regulator-always-on or
> + * regulator-boot-on DT property, trigger probe() to
> + * configure its default state during startup.
> + */
> + if (uc_pdata->always_on && uc_pdata->boot_on)
This check for always_on _and_ boot_on does not fully match the commit
message, comment or the old behavior of regulators_enable_boot_on()
where any always_on _or_ boot_on would trigger autoset().
Regards,
Jonas
> + dev_or_flags(dev, DM_FLAG_PROBE_AFTER_BIND);
>
> - return -EINVAL;
> + return 0;
> }
>
[snip]
