Hi Simon, > There has been an LED framework in U-Boot which uses driver model for > about 9 years now. Recent work is underway to improve it and provide > more features. It is probably a good time to drop the old code, which > is only used by 5 boards: > > ./tools/qconfig.py -f LED_STATUS > 5 matches > eb_cpu5282 eb_cpu5282_internal mx23_olinuxino pinephone > socfpga_vining_fpga
Why aren't these boards being migrated to what ever the new frame work is rather than dropping quite useful functionality on these devices? > This series attempts that. > > > Simon Glass (27): > led: Drop LED_STATUS_BOARD_SPECIFIC > arm: Drop old LED support > common: doc: Drop old LED support > st: stm32f429: Drop old LED code > led: Make the LED config common > eb_cpu5282: Drop STATUS_LED > mx23_olinuxino: Drop STATUS_LED > pinephone: Drop STATUS_LED > socfpga_vining_fpga: Drop STATUS_LED > led: Drop LED_STATUS from Kconfig > led: Drop the legacy LED command > misc: Drop gpio_led driver > pca9551_led: Delete driver > misc: status_led: Delete driver > m68k: Drop unused status_led.h header file > powerpc: Drop status-LED code > eb_cpu5282: Drop status-LED code > igep00x0: Drop unused status_led.h header file > mx23_olinuxino: Drop status-LED code > vining_fpga: Drop status-LED code > sunxi: Drop status-LED code > common: Drop status-LED code in board_r > image: Drop unused status_led.h header file > ide: Drop unused status_led.h header file > mpc83xx: Drop status-LED code > net: Drop status-LED code > led: Drop status_led header file > > arch/arm/lib/crt0.S | 4 - > arch/m68k/lib/bootm.c | 3 - > arch/powerpc/lib/interrupts.c | 6 - > board/BuS/eb_cpu5282/eb_cpu5282.c | 20 -- > board/isee/igep00x0/igep00x0.c | 1 - > board/olimex/mx23_olinuxino/mx23_olinuxino.c | 7 - > board/softing/vining_fpga/socfpga.c | 4 - > board/st/stm32f429-discovery/Makefile | 1 - > board/st/stm32f429-discovery/led.c | 39 --- > board/sunxi/board.c | 6 - > boot/image.c | 4 - > cmd/Makefile | 1 - > cmd/ide.c | 4 - > cmd/legacy_led.c | 185 ---------- > common/board_f.c | 22 -- > common/board_r.c | 16 - > configs/eb_cpu5282_defconfig | 6 - > configs/eb_cpu5282_internal_defconfig | 6 - > configs/mx23_olinuxino_defconfig | 8 - > configs/pinephone_defconfig | 5 - > configs/socfpga_vining_fpga_defconfig | 11 - > doc/README.LED | 77 ----- > drivers/led/Kconfig | 342 +------------------ > drivers/misc/Kconfig | 13 - > drivers/misc/Makefile | 3 - > drivers/misc/gpio_led.c | 106 ------ > drivers/misc/pca9551_led.c | 170 --------- > drivers/misc/status_led.c | 124 ------- > drivers/timer/mpc83xx_timer.c | 5 - > include/configs/eb_cpu5282.h | 6 - > include/status_led.h | 102 ------ > net/bootp.c | 7 - > net/net.c | 33 -- > 33 files changed, 11 insertions(+), 1336 deletions(-) > delete mode 100644 board/st/stm32f429-discovery/led.c > delete mode 100644 cmd/legacy_led.c > delete mode 100644 doc/README.LED > delete mode 100644 drivers/misc/gpio_led.c > delete mode 100644 drivers/misc/pca9551_led.c > delete mode 100644 drivers/misc/status_led.c > delete mode 100644 include/status_led.h > > -- > 2.43.0 >
