On 10/1/24 7:05 AM, Venkatesh Yadav Abbarapu wrote:

[...]

+static const struct onboard_hub_data usb5744_data = {
+       .reset_us = 10000,
+       .power_on_delay_us = 10000,
+};
+
  static const struct udevice_id usb_onboard_hub_ids[] = {
        /* Use generic usbVID,PID dt-bindings (usb-device.yaml) */
-       { .compatible = "usb424,2514" }, /* USB2514B USB 2.0 */
-       { }
+       {       .compatible = "usb424,2514" /* USB2514B USB 2.0 */
+       }, {
+               .compatible = "usb424,2744", /* USB2744 USB 2.0 */
+               .data = (ulong)&usb5744_data,
+       }, {
+               .compatible = "usb424,5744", /* USB5744 USB 3.0 */
+               .data = (ulong)&usb5744_data,
+        }
+
  };
Consistently indent with TABs and drop the extra newline after } .

Does checkpatch not warn about this ?

Reply via email to