Hi Maksim, Thank you for the patch and sorry for the review delay.
On jeu., sept. 19, 2024 at 16:58, [email protected] wrote: > From: Maksim Kiselev <[email protected]> > > Some USB-ETH adapters based on the AX88179 (ex. D-link DUB-2312) > has link issue if ADVERTISE_NPAGE flag is set. Do you see the issue only if ADVERTISE_NPAGE is set? What about ADVERTISE_LPACK ? Could you detail a bit what you mean by link issue? > > Also Linux drivers for ASIX chips doesn't use these flags. I've double checked this looking on master, commit 87d6aab2389e ("Merge tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost") I inspected asix_devices.c and ax88179_178a.c and I could indeed not find anything related to ADVERTISE_LPACK and ADVERTISE_NPAGE. I'm not super knowledgeable on network so I'd like someone else to test this as well, if possible. > > Signed-off-by: Maksim Kiselev <[email protected]> > --- > drivers/usb/eth/asix88179.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/eth/asix88179.c b/drivers/usb/eth/asix88179.c > index 4bd3b9d10d..1f469a1a7d 100644 > --- a/drivers/usb/eth/asix88179.c > +++ b/drivers/usb/eth/asix88179.c > @@ -345,8 +345,8 @@ static int asix_basic_reset(struct ueth_data *dev, > asix_write_cmd(dev, AX_ACCESS_MAC, AX_MEDIUM_STATUS_MODE, 2, 2, tmp16); > > u16 adv = 0; > - adv = ADVERTISE_ALL | ADVERTISE_CSMA | ADVERTISE_LPACK | > - ADVERTISE_NPAGE | ADVERTISE_PAUSE_ASYM | ADVERTISE_PAUSE_CAP; > + adv = ADVERTISE_ALL | ADVERTISE_CSMA | ADVERTISE_PAUSE_ASYM | > + ADVERTISE_PAUSE_CAP; > asix_write_cmd(dev, AX_ACCESS_PHY, 0x03, MII_ADVERTISE, 2, &adv); > > adv = ADVERTISE_1000FULL; > -- > 2.45.2
