On Tue, Oct 08, 2024 at 07:55:33PM -0600, Simon Glass wrote: > On Sat, 5 Oct 2024 at 13:14, Andy Shevchenko > <[email protected]> wrote: > > > > The compiler is not happy to have no prototypes for the functions that > > are not defined static. Add them. This helps avoiding the compiler warnings: > > > > arch/x86/cpu/cpu.c:197:13: warning: no previous prototype for > > ‘board_final_init’ [-Wmissing-prototypes] > > arch/x86/cpu/cpu.c:205:13: warning: no previous prototype for > > ‘board_final_cleanup’ [-Wmissing-prototypes] > > arch/x86/cpu/cpu.c:307:5: warning: no previous prototype for > > ‘reserve_arch’ [-Wmissing-prototypes] > > Reviewed-by: Simon Glass <[email protected]>
Thanks! > OK, but could you add proper comments for these? Any proposed texts for them? The comments were out of scope of my patch, but I may add anything that is provided as a template. -- With Best Regards, Andy Shevchenko
