Hello Mattijs, On Fri, Oct 11, 2024 at 04:22:43PM +0200, Mattijs Korpershoek wrote: > Hi Dmitry, > > On jeu., oct. 10, 2024 at 14:17, "Mattijs Korpershoek via groups.io" > <[email protected]> wrote: > > [...] > > >>> > > > >>> > > Reviewed-by: Simon Glass <[email protected]> > >>> > > > >>> > > Can you also update the test? > >>> > > >>> > I apologize, but I didn't quite understand your point. Could you please > >>> > clarify? This patch series includes additional tests for the 'ab_dump' > >>> > subcommand. For more details, please refer to: > >>> > > >>> > https://lore.kernel.org/all/[email protected]/ > >>> > >>> OK, thank you. Sometimes it is easier (for reviewers) if you update > >>> the test in the same commit. > >> > >> Should I resend the patch series with ab_dump implementation and tests > >> in the same commit? > >> > >> I can prepare new version, if needed, no problem. > > > > No need to resend a new version just for this, since it's already > > been reviewed. > > > > Keep the suggestion in mind for future series! > > If you do need to re-spin this as v4, you can squash the test commit > with this one if you wish.
Of course, I can re-spin that. I believe I can save all RvB trailers during the squashing process. Could you please clarify if my understanding is correct? -- Thank you, Dmitry
