Thanks, I can confirm this fixes the issue for me (405EX Rev. D with
security).
Still checkpatch finds some whitespace issues:
.dotest/patch:13: space before tab in indent.
defined(CONFIG_405EX_CHIP21_PVR_REV_D) && \
.dotest/patch:27: trailing whitespace.
*
warning: 2 lines add whitespace errors.
> diff --git a/include/configs/kilauea.h
> b/include/configs/kilauea.h index 031f8fb..2d3efba 100644
> --- a/include/configs/kilauea.h
> +++ b/include/configs/kilauea.h
> @@ -44,6 +44,17 @@
> #endif
>
> /*
> + * CHIP_21 errata
> + */
> +//#define CONFIG_405EX_CHIP21_PVR_REV_C
> 0x1291147f /* EX with security */
> +//#define CONFIG_405EX_CHIP21_PVR_REV_D
> 0x12911475 /* EX with security */
> +//#define CONFIG_405EX_CHIP21_ECID3_REV_D 0x0
> /* EX with security */
> +
> +#define CONFIG_405EX_CHIP21_PVR_REV_C
> 0x1291147d /* EX without security */
> +#define CONFIG_405EX_CHIP21_PVR_REV_D
> 0x12911473 /* EX without security */
> +#define CONFIG_405EX_CHIP21_ECID3_REV_D 0x1
> /* EX without security */
I don't like defining expected PVR values in the board config file.
Maybe something like CONFIG_405EX_CHIP21_SECURITY and
CONFIG_405EX_CHIP21_NO_SECURITY would be more pleasant.
Then you could place
#ifdef CONFIG_405EX_CHIP21_SECURITY
#define CONFIG_405EX_CHIP21_PVR_REV_C 0x1291147f /* EX with
security */
#define CONFIG_405EX_CHIP21_PVR_REV_D 0x12911475 /* EX with
security */
#define CONFIG_405EX_CHIP21_ECID3_REV_D 0x0 /* EX with
security */
#endif
#ifdef CONFIG_405EX_CHIP21_NO_SECURITY
#define CONFIG_405EX_CHIP21_PVR_REV_C 0x1291147d /* EX without
security */
#define CONFIG_405EX_CHIP21_PVR_REV_D 0x12911473 /* EX without
security */
#define CONFIG_405EX_CHIP21_ECID3_REV_D 0x1 /* EX without
security */
#endif
in a more appropriate place.
Cheers
Dirk
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
