Hi Raymond, On Tue, 22 Oct 2024 at 22:07, Raymond Mao <[email protected]> wrote: > > Current smbios library does not fully match to the specification. > It hardcodes values instead of exposing values from the device. > It does not support dynamic length for contained object handles > or elements and misses the handling of a few of fields. > > The refactoring of this patch includes: > 1. Expose values from device via sysinfo interface. > 2. Replace smbios_add_prop with smbios_add_prop_si to allow getting > string values from sysinfo. > 3. Add smbios_get_val_si to get int values from sysinfo. > 4. Use sysinfo_get_data to get data area. > 5. Miscellaneous fixes in smbios. > > Moreover, this patch adds SMBIOS type 7 (cache information) write > functions. > Link cache handles from type 7 to type 4. > > Signed-off-by: Raymond Mao <[email protected]> > --- > Changes in v2 > - Combine with #7(v1) patch. > - Move the changes of cmd/smbios.c to a separated patch. > - Refactor smbios_get_val_si to get values from dt when values are > not available from sysinfo driver. > - Miscellaneous refactoring. > > include/smbios.h | 14 +- > lib/smbios.c | 420 +++++++++++++++++++++++++++++++++++++++++------ > 2 files changed, 383 insertions(+), 51 deletions(-) >
There's an awful lot in this patch. Can it be split up? Regards, Simon
