On Wed, Nov 13, 2024 at 11:53:34AM -0700, Simon Glass wrote:

> Add instructions on how to build the file for multiple architectures.
> Add a message indicating what is happening.
> 
> Update the documentation as well.
> 
> Signed-off-by: Simon Glass <[email protected]>
[snip]
>  Or to use an existing container
>  
>  .. code-block:: bash
>  
> -    sudo docker pull trini/u-boot-gitlab-ci-runner:jammy-20240227-14Mar2024
> +    docker pull trini/u-boot-gitlab-ci-runner:jammy-20240227-14Mar2024

You inadvertently dropped sudo here.

> diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile
> index 967ac89fbde..7f4b17ab0a4 100644
> --- a/tools/docker/Dockerfile
> +++ b/tools/docker/Dockerfile
> @@ -2,13 +2,25 @@
>  # This Dockerfile is used to build an image containing basic stuff to be used
>  # to build U-Boot and run our test suites.
>  
> +# Build with (for example):
> +# docker buildx build --platform linux/arm64/v8,linux/amd64 --tag 
> sjg20/u-boot-gitlab-ci-runner-multiarch:jammy-20240808-03Nov2024 .
> +

The documentation is the example, please drop.

With those fixed:

Reviewed-by: Tom Rini <[email protected]>

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to