Hi Paul, On Wed, 20 Nov 2024 at 03:40, Paul HENRYS <[email protected]> wrote: > > This change allows to replace both 'SEQ' and 'NAME' keywords by respectively a > sequence number and the name of the FDT to provide more flexibility in the > node > name for the device trees included in the FIT.
This seems OK to me, but it would help to understand the motivation better. Can you expand this a bit? > > Signed-off-by: Paul HENRYS <[email protected]> > --- > tools/binman/etype/fit.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/binman/etype/fit.py b/tools/binman/etype/fit.py > index e0c1ac08d8..b9ebc3afd0 100644 > --- a/tools/binman/etype/fit.py > +++ b/tools/binman/etype/fit.py > @@ -732,6 +732,7 @@ class Entry_fit(Entry_section): > # Generate nodes for each FDT > for seq, fdt_fname in enumerate(self._fdts): > node_name = node.name[1:].replace('SEQ', str(seq + 1)) > + node_name = node_name.replace('NAME', fdt_fname) > if self._fdt_dir: > fname = os.path.join(self._fdt_dir, fdt_fname + > '.dtb') > else: > -- > 2.43.0 Please update the documentation (near the top of this file) and regenerate entries.rst It also needs a test so that coverage passes (binman test -T)... [..] Regards, Simon
