On Mon, Dec 02, 2024 at 05:22:44PM -0700, Simon Glass wrote: > Hi Tom, > > On Mon, 2 Dec 2024 at 13:18, Tom Rini <[email protected]> wrote: > > > > On Sun, Dec 01, 2024 at 08:24:23AM -0700, Simon Glass wrote: > > > > > Some functions are passing addresses instead of pointers to the > > > efi_add_memory_map() function. This confusion is understandable since > > > the function arguments indicate an address. > > > > > > Make a note of the 8 places where there are problems, which would break > > > usage in sandbox tests. > > > > > > Future work will resolve these problems. > > > > > > Signed-off-by: Simon Glass <[email protected]> > > > > Please just resolve these rather than introducing a patch to then fix > > them later. This is something that should have been fixup'd before > > posting. Thanks. > > That was deliberate, as I wanted people to see the problems. It will > save discussion on later patches where the problems are fixed, if we > can agree that these are actual problems. If people are happy to add > review tags to the later patches then I'm happy to redo it.
No, please drop this patch. A "TODO: This is wrong" in several places and then changing it in another patch does not help. -- Tom
signature.asc
Description: PGP signature
