Hi, On Wed, 4 Dec 2024 at 08:01, Jonas Karlman <[email protected]> wrote: > > Hi Heinrich, > > On 2024-12-04 13:10, Heinrich Schuchardt wrote: > > Dear Tom, > > > > The following changes since commit f96e5133184aac377b54bd61f8abf78710f2ee56: > > > > Merge branch 'master' of > > https://gitlab.denx.de/u-boot/custodians/u-boot-samsung (2024-12-03 > > 12:37:20 -0600) > > > > are available in the Git repository at: > > > > https://source.denx.de/u-boot/custodians/u-boot-efi.git > > tags/efi-2025-01-rc4 > > > > for you to fetch changes up to 657310322e5893d0b1bbba002fbe59b318062192: > > > > doc: environment: NET_LWIP dhcp sets ipaddrN, netmaskN and gatewayipN > > (2024-12-04 11:26:34 +0100) > > > > Gitlab CI showed no issues: > > https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/23706 > > > > ---------------------------------------------------------------- > > Pull-request efi-2025-01-rc4 > > > > With the move to bootstd booting via the EFI boot manager stopped to > > consider all block devices due to missing probing. > > > > With this pull request probing of all bootdevs before running the boot > > manager is achieved. Prerequisite changes are needed to pass the CI. > > > > efi_loader: simplify efi_disk_rw_blocks() > > test: fix test_extension.py > > configs: sandbox_deconfig: remove CONFIG_AMIGA_PARTITION > > CI: xilinx_versal_virt: disable USB_DWC3 > > net: eth_bootdev_hunt() should not run DHCP > > cmd: bootmenu: add parameter -e for UEFI boot options > > efi_loader: run bootdev_hunt() to find ESP > > As pointed out in v1 of this patch, this cause a serious slowed down > boot for bootstd boards using scripts and extlinux boot due to usb and > pci being initialized before boot_targets order is considered. > > With this merged we probably need to disable BOOTMETH_EFI_BOOTMGR for > bootstd/Rockchip. Seem very late in release to merge this big change! > > Regards, > Jonas > > > > > Further UEFI changes: > > > > Avoid writing message in Exit() boot service > > Update startimage_exit self-test to check error > > Don't warn if the TCG2 FinalEvents table is not installed > > > > Documentation changes: > > > > cmd: bootmenu typo 'read' > > clk: mpc83xx: Fix typo in "Coherent System Bus" > > efi_loader: Fix typos in enum efi_allocate_type > > doc: sending_patches: Fix spelling of "its" > > doc: environment: NET_LWIP dhcp sets ipaddrN, netmaskN and gatewayipN > > doc: board: theobroma-systems: fix feature list in introductions > > > > ---------------------------------------------------------------- > > Andy Yan (1): > > doc: coolpi: Fix document style > > > > Heinrich Schuchardt (9): > > efi_loader: simplify efi_disk_rw_blocks() > > test: fix test_extension.py > > configs: sandbox_deconfig: remove CONFIG_AMIGA_PARTITION > > CI: xilinx_versal_virt: disable USB_DWC3 > > net: eth_bootdev_hunt() should not run DHCP > > cmd: bootmenu: add parameter -e for UEFI boot options > > efi_loader: run bootdev_hunt() to find ESP > > cmd: bootmenu typo 'read' > > efi_loader: avoid writing message in Exit() boot service > > > > Ilias Apalodimas (1): > > efi_loader: Don't warn if the TCG2 FinalEvents table is not installed > > > > J. Neuschäfer (2): > > clk: mpc83xx: Fix typo in "Coherent System Bus" > > doc: sending_patches: Fix spelling of "its" > > > > Jerome Forissier (1): > > doc: environment: NET_LWIP dhcp sets ipaddrN, netmaskN and gatewayipN > > > > Quentin Schulz (1): > > doc: board: theobroma-systems: fix feature list in introductions > > > > Simon Glass (2): > > efi_loader: Fix typos in enum efi_allocate_type > > efi_loader: Update startimage_exit self-test to check error > > > > .azure-pipelines.yml | 1 + > > .gitlab-ci.yml | 1 + > > cmd/bootmenu.c | 41 > > +++++++++++++++++++------ > > configs/sandbox_defconfig | 1 - > > doc/board/coolpi/genbook_cm5_rk3588.rst | 11 ++++--- > > doc/board/theobroma-systems/puma_rk3399.rst | 1 + > > doc/board/theobroma-systems/tiger_rk3588.rst | 7 +++++ > > doc/develop/sending_patches.rst | 2 +- > > doc/usage/cmd/bootmenu.rst | 13 ++++++-- > > doc/usage/environment.rst | 31 ++++++++++--------- > > drivers/clk/mpc83xx_clk.h | 2 +- > > include/efi.h | 2 +- > > lib/efi_loader/efi_boottime.c | 7 ++--- > > lib/efi_loader/efi_disk.c | 8 ++--- > > lib/efi_loader/efi_setup.c | 8 +++++ > > lib/efi_loader/efi_tcg2.c | 2 +- > > lib/efi_selftest/efi_selftest_startimage_exit.c | 6 ++-- > > net/eth_bootdev.c | 30 ++++++++++-------- > > test/py/tests/test_extension.py | 4 ++- > > 19 files changed, 116 insertions(+), 62 deletions(-) > > >
Yes, this change[1] looks innocuous but since the bootmgr problem has not been solved. This definitely should not go into master, sorry. So NAK from me Regards, Simon [1] https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
