> -----Original Message----- > From: Tudor Ambarus <[email protected]> > Sent: Thursday, December 5, 2024 1:20 PM > To: Abbarapu, Venkatesh <[email protected]>; [email protected]; > [email protected] > Cc: Simek, Michal <[email protected]>; [email protected]; > [email protected]; [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; git (AMD-Xilinx) <[email protected]> > Subject: Re: [PATCH v2] mtd: spi-nor: Enable mt35xu512aba_fixups for all > mt35xx > flashes > > > > On 12/5/24 4:29 AM, Venkatesh Yadav Abbarapu wrote: > > Add SPI_NOR_OCTAL_DTR_READ flags to micron flashes mt35xu01g and > > mt35xu02g. Also move them under CONFIG_SPI_FLASH_MT35XU config, so > > that in driver mt35xu512aba_fixups will be applied. > > Why? What problem are you trying to solve? Should we have a fixes tag?
These two flashes mt35xu01g and mt35xu02g support DTR, so updated the flag SPI_NOR_OCTAL_DTR_READ which in turn uses this spi_nor_micron_octal_dtr_enable. Adding the support, not fixing anything. Let me know if anything missing from my side. > Why didn't you split these 2 changes in 2 dedicated patches? Sure. Will split to two separate patches. Thanks Venkatesh > > Please read the following before submitting v3: > https://docs.u-boot.org/en/latest/develop/sending_patches.html > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe- > your-changes
