> -----Original Message----- > From: Chee, Tien Fong <[email protected]> > Sent: Thursday, 19 December, 2024 9:51 AM > To: Zamri, Muhammad Hazim Izzat > <[email protected]>; [email protected] > Cc: Marek <[email protected]>; Simon <[email protected]>; > Tom Rini <[email protected]>; Meng, Tingting > <[email protected]>; Hea, Kok Kiang <[email protected]>; > Maniyam, Dinesh <[email protected]>; Ng, Boon Khai > <[email protected]>; Yuslaimi, Alif Zakuan > <[email protected]>; Lim, Jit Loon <[email protected]>; > Tang, Sieu Mun <[email protected]> > Subject: RE: [PATCH v1 1/1] arm: socfpga:agilex5: Fix system manager > watchdog mode setting > > Hi Hazim, > > > -----Original Message----- > > From: Zamri, Muhammad Hazim Izzat > > <[email protected]> > > Sent: Thursday, December 5, 2024 11:56 AM > > To: [email protected] > > Cc: Marek <[email protected]>; Simon > <[email protected]>; > > Tom Rini <[email protected]>; Chee, Tien Fong > > <[email protected]>; Meng, Tingting <[email protected]>; > > Hea, Kok Kiang <[email protected]>; Maniyam, Dinesh > > <[email protected]>; Ng, Boon Khai <[email protected]>; > > Yuslaimi, Alif Zakuan <[email protected]>; Zamri, > > Muhammad Hazim Izzat <[email protected]>; Lim, > Jit > > Loon <[email protected]>; Tang, Sieu Mun > > <[email protected]> > > Subject: [PATCH v1 1/1] arm: socfpga:agilex5: Fix system manager > > watchdog mode setting > > > > From: Muhammad Hazim Izzat Zamri > > <[email protected]> > > > > This commit is to fix the system manager watchdog mode setting to > > support until mode_4 for Agilex5. This changes can refer to system > > manager register map on wddbg fields. > > You need to improve the commit message, the commit message should > contains the description of issue you want to fix such as why no issue in > Agilex device, and what / why this solution? > > [...] > > Regards, > Tien Fong
Hi Tien Fong, Okay got it. Will work on improving the commit message. Thanks, Hazim
