On Thu, Dec 19, 2024 at 7:50 PM david regan <[email protected]> wrote:
> Update bcmbca dts to current nand node naming convention. > > Signed-off-by: david regan <[email protected]> > Reviewed-by: William Zhang <[email protected]> > Reviewed-by: Anand Gore <[email protected]> Looks like a reasonable step Acked-by: Linus Walleij <[email protected]> But: > - nandcs@0 { > - compatible = "brcm,nandcs"; > - reg = <0>; > - nand-ecc-strength = <4>; > - nand-ecc-step-size = <512>; > - brcm,nand-oob-sector-size = <16>; > - }; > +&nandcs { > + nand-on-flash-bbt; > + nand-ecc-strength = <4>; > + nand-ecc-step-size = <512>; > + brcm,nand-oob-sector-size = <16>; So you're adding nand-on-flash-bbt, maybe we should notice this? Do you have to use the explicit ECC config, or can you just use Williams new option brcm,nand-ecc-use-strap; ? (This can be changed in an additional patch.) Yours, Linus Walleij
