On Tue, 17 May 2011 10:11:14 -0400
Alex Waterman <awater...@dawning.com> wrote:

> I have seen issues with the nand_read_byte16() function in nand_base.c; it 
> seems like the cpu_to_le16() should be the other way around: le16_to_cpu(). 
> Other than that no bugs as far as I am aware.

What is the specific problem you're seeing?  The use of these endian macros
is a bit abusive and ugly (what's really wanted is native-endian I/O
accessors -- readw() has an implicit le16_to_cpu()), and should have been
done internally to the read_word() implementation rather than made part of
the API, but functionally it should be correct.

-Scott

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to