On 25/01/2025 12:30, Marek Vasut wrote: > On 1/21/25 1:03 PM, Paul Barker wrote: >> On 18/01/2025 06:16, Marek Vasut wrote: >>> Replace ifdeffery with plain debug() function call. No functional change. >>> >>> Signed-off-by: Marek Vasut <[email protected]> >>> --- >>> Cc: Adam Ford <[email protected]> >>> Cc: Hai Pham <[email protected]> >>> Cc: Ilias Apalodimas <[email protected]> >>> Cc: Jerome Forissier <[email protected]> >>> Cc: Joe Hershberger <[email protected]> >>> Cc: Mario Six <[email protected]> >>> Cc: Nobuhiro Iwamatsu <[email protected]> >>> Cc: Paul Barker <[email protected]> >>> Cc: Peter Robinson <[email protected]> >>> Cc: Ramon Fried <[email protected]> >>> Cc: Sumit Garg <[email protected]> >>> Cc: Tom Rini <[email protected]> >>> Cc: [email protected] >>> --- >>> drivers/net/phy/miiphybb.c | 4 +--- >>> 1 file changed, 1 insertion(+), 3 deletions(-) >>> >>> diff --git a/drivers/net/phy/miiphybb.c b/drivers/net/phy/miiphybb.c >>> index 171c1719b5b..5497b838225 100644 >>> --- a/drivers/net/phy/miiphybb.c >>> +++ b/drivers/net/phy/miiphybb.c >>> @@ -183,9 +183,7 @@ int bb_miiphy_read(struct mii_dev *miidev, int addr, >>> int devad, int reg) >>> bus->set_mdc(bus, 1); >>> bus->delay(bus); >>> >>> -#ifdef DEBUG >>> - printf("miiphy_read(0x%x) @ 0x%x = 0x%04x\n", reg, addr, rdreg); >>> -#endif >>> + debug("miiphy_read(0x%x) @ 0x%x = 0x%04x\n", reg, addr, rdreg); >>> >>> return rdreg; >>> } >> >> While we're here, can we include the bus name in the output to avoid >> confusion when we have multiple buses? Maybe something like: >> >> debug("miiphy_read(0x%x) @ %s:0x%x = 0x%04x\n", reg, bus->name, addr, >> rdreg); > No, not in this patch, but please test: > > [PATCH] net: miiphybb: Update debug() print > > Is it OK with you if I pick this patch for upcoming release ?
Yes please. Reviewed-by: Paul Barker <[email protected]> -- Paul Barker
OpenPGP_0x27F4B3459F002257.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
