Re: [U-Boot] [PATCH 3/3] common/cmd_ximg.c: add ifdef protection for gzip uncompression

[Mike Frysinger]

On Monday, May 23, 2011 14:29:13 Matthew McClintock wrote:
> --- a/common/cmd_ximg.c
> +++ b/common/cmd_ximg.c
>                       break;
>               case IH_COMP_GZIP:
> +#ifdef CONFIG_GZIP
>                       printf ("   Uncompressing part %d ... ", part);
>                       if (gunzip ((void *) dest, unc_len,
>                                   (uchar *) data, &len) != 0) {
>                               puts ("GUNZIP ERROR - image not loaded\n");
>                               return 1;
>                       }
> +#else
> +                     printf("    gzip decompression not supported in this"
> +                             " build!\n");
> +                     return 1;
> +#endif

a few things ...
 - dont split string constants
 - if you arent using any formats, then puts() is better
 - the #else isnt even necessary ... wrap the "case" in the #ifdef too, and 
then at runtime this will automatically fall through to the already existing 
default: case
-mike

signature.asc
Description: This is a digitally signed message part.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot