Hi Jonas, On Sat, 8 Feb 2025 at 18:27, Jonas Karlman <[email protected]> wrote: > > Hi Simon, > > On 2025-02-09 00:04, Simon Glass wrote: > > Hi Jonas, > > > > On Thu, 12 Dec 2024 at 16:57, Jonas Karlman <[email protected]> wrote: > >> > >> Use the offset configured with SYS_SPI_U_BOOT_OFFS Kconfig option > >> instead of a hardcoded 0x40000 for the FIT payload offset. > >> > >> This has no intended impact as SYS_SPI_U_BOOT_OFFS=0x40000. > > > > When you add CONFIG options into a devicetree, it makes it difficult > > to build it. We have to individually build U-Boot for each target just > > to get the right values. > > This only aligned everything with the simple-bin-spi image and prepared > for moving the SPI flash payload offset to 0xE0000. > > If you are looking at this now, please also take a look at [1]. There > where some questions directed at you there :-) > > [1] > https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/ > > > > > For rk3399-generic, this means I have to drop gru. > > > > Can we not use a binman symbols instead? > > All RK3399 targets having support for building a SPI flash image now use > CONFIG_SYS_SPI_U_BOOT_OFFS=0xE0000 after these changes where merged.
OK, but why have this config option? Binman is designed to remove the need for it. Regards, Simon
