Thanks for the CC Heinrich I actually lost that on the ML
On Thu, 20 Feb 2025 at 09:40, Heinrich Schuchardt <[email protected]> wrote: > > On 1/17/25 18:13, Vincent Stehlé wrote: > > Add more EFI protocols GUIDs to the translation table used by > > uuid_guid_get_str(). > > > > Signed-off-by: Vincent Stehlé <[email protected]> > > Cc: Tom Rini <[email protected]> > > Reviewed-by: Heinrich Schuchardt <[email protected]> > > > --- > > > > Hi, > > > > While the EFI_LOADED_IMAGE_DEVICE_PATH_PROTOCOL_GUID, the > > EFI_HII_CONFIG_ACCESS_PROTOCOL_GUID and the EFI_LOAD_FILE_PROTOCOL_GUID are > > actually used by the efi_loader, this is not the case with the > > EFI_DISK_IO_PROTOCOL_GUID. > > I think we should add this GUID to the table nonetheless, as it can help > > with debugging EFI applications and we already have this GUID's definition > > in the headers. > > If that is not desired, please do not hesitate to drop the first hunk of > > this patch. > > > > Best regards, > > Vincent. > > > > lib/uuid.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/lib/uuid.c b/lib/uuid.c > > index 97388f597a6..75658778044 100644 > > --- a/lib/uuid.c > > +++ b/lib/uuid.c > > @@ -119,6 +119,10 @@ static const struct { > > "Block IO", > > EFI_BLOCK_IO_PROTOCOL_GUID, > > }, > > + { > > + "Disk IO", > > + EFI_DISK_IO_PROTOCOL_GUID, > > + }, > > { > > "Simple File System", > > EFI_SIMPLE_FILE_SYSTEM_PROTOCOL_GUID, > > @@ -127,6 +131,10 @@ static const struct { > > "Loaded Image", > > EFI_LOADED_IMAGE_PROTOCOL_GUID, > > }, > > + { > > + "Loaded Image Device Path", > > + EFI_LOADED_IMAGE_DEVICE_PATH_PROTOCOL_GUID, > > + }, > > { > > "Graphics Output", > > EFI_GRAPHICS_OUTPUT_PROTOCOL_GUID, > > @@ -139,10 +147,18 @@ static const struct { > > "HII Database", > > EFI_HII_DATABASE_PROTOCOL_GUID, > > }, > > + { > > + "HII Config Access", > > + EFI_HII_CONFIG_ACCESS_PROTOCOL_GUID, > > + }, > > { > > "HII Config Routing", > > EFI_HII_CONFIG_ROUTING_PROTOCOL_GUID, > > }, > > + { > > + "Load File", > > + EFI_LOAD_FILE_PROTOCOL_GUID, > > + }, > > { > > "Load File2", > > EFI_LOAD_FILE2_PROTOCOL_GUID, > Reviewed-by: Ilias Apalodimas <[email protected]>
