> -----Original Message-----
> From: Tom Rini <[email protected]>
> Sent: Saturday, 15 March 2025 12:53 am
> To: Maniyam, Dinesh <[email protected]>
> Cc: [email protected]; Marek <[email protected]>; Simon
> <[email protected]>; Simon Glass <[email protected]>; Dario
> Binacchi <[email protected]>; Ilias Apalodimas
> <[email protected]>; Heinrich Schuchardt <[email protected]>;
> Jerome Forissier <[email protected]>; Mattijs Korpershoek
> <[email protected]>; Ibai Erkiaga <[email protected]>;
> Michal Simek <[email protected]>; Dmitry Rokosov
> <[email protected]>; Jonas Karlman <[email protected]>; Sebastian
> Reichel <[email protected]>; Meng, Tingting
> <[email protected]>; Chee, Tien Fong <[email protected]>;
> Hea, Kok Kiang <[email protected]>; Ng, Boon Khai
> <[email protected]>; Yuslaimi, Alif Zakuan
> <[email protected]>; Zamri, Muhammad Hazim Izzat
> <[email protected]>; Lim, Jit Loon
> <[email protected]>; Tang, Sieu Mun <[email protected]>
> Subject: Re: [resend v2 06/13] drivers: i3c: Add i3c sandbox simple test.
>
> On Fri, Mar 14, 2025 at 12:08:55PM +0800, [email protected] wrote:
>
> > From: Dinesh Maniyam <[email protected]>
> >
> > Add s simple test for the I3C uclass in sandbox.
> >
> > Signed-off-by: Dinesh Maniyam <[email protected]>
> [snip]
> > diff --git a/drivers/i3c/sandbox_i3c.c b/drivers/i3c/sandbox_i3c.c new
> > file mode 100755 index 00000000000..99ce769988d
> > --- /dev/null
> > +++ b/drivers/i3c/sandbox_i3c.c
> > @@ -0,0 +1,58 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (C) 2025 Altera Corporation <www.altera.com> */
> > +
> > +#include <dm.h>
> > +#include <errno.h>
> > +#include <i3c.h>
> > +#include <linux/i3c/master.h>
> > +
> > +DECLARE_GLOBAL_DATA_PTR;
>
> Here and elsewhere in the series, audit for adding DECLARE_GLOBAL_DATA_PTR
> without a "gd->" in the code.
>
> --
> Tom
Apologies. I shall remove the DECLARE_GLOBAL_DATA_PTR
because there is no usage of gd-> in the code.
Thanks.
Dinesh