Dear Rob Herring,

In message <[email protected]> you wrote:
> From: Rob Herring <[email protected]>
> 
> Add support for AHCI controllers that are not PCI based.


...
> +     memset((void *)ataid, 0, sizeof(hd_driveid_t *) * AHCI_MAX_PORTS);

This triggers a checkpatch error.

Why don;t you simply write:

        memset((void *)ataid, 0, sizeof(ataid)):

?

> +      err_out:

labels should not be indented


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected]
For every complex problem, there is a solution that is simple,  neat,
and wrong.                                               - Mark Twain
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to