Hi, On 2025-03-10 15:00, [email protected] wrote: > From: Jiehui He <[email protected]> > > The LCKFB TaishanPi is a single-board computer based on the RK3566 SoC. > > Specification: > - 1/2 Gib RAM > - Optinal EMMC > - SD-Card > - HDMI / MIPI CSI / MIPI DSI > - USB 2.0 Host (Type-A) > - USB 2.0 Host / OTG (Type-C) > - No Ethernet > > This patch adds U-Boot support for the LCKFB TaishanPi RK3566 board. > It includes: > - Device tree file for U-Boot > - Default configuration > - Documentation update > - MAINTAINERS update > > Signed-off-by: Jiehui He <[email protected]> > --- > arch/arm/dts/rk3566-lckfb-tspi-u-boot.dtsi | 11 +++ > board/rockchip/evb_rk3568/MAINTAINERS | 6 ++ > configs/lckfb-tspi-rk3566_defconfig | 84 ++++++++++++++++++++++ > doc/board/rockchip/rockchip.rst | 1 + > 4 files changed, 102 insertions(+) > create mode 100644 arch/arm/dts/rk3566-lckfb-tspi-u-boot.dtsi > create mode 100644 configs/lckfb-tspi-rk3566_defconfig > > diff --git a/arch/arm/dts/rk3566-lckfb-tspi-u-boot.dtsi > b/arch/arm/dts/rk3566-lckfb-tspi-u-boot.dtsi > new file mode 100644 > index 00000000..0c8e7018 > --- /dev/null > +++ b/arch/arm/dts/rk3566-lckfb-tspi-u-boot.dtsi > @@ -0,0 +1,11 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > + > +#include "rk356x-u-boot.dtsi" > + > +&rgb_led_r { > + default-state = "off"; > +}; > + > +&rgb_led_b { > + default-state = "off"; > +}; > diff --git a/board/rockchip/evb_rk3568/MAINTAINERS > b/board/rockchip/evb_rk3568/MAINTAINERS > index b2780401..6cf568ad 100644 > --- a/board/rockchip/evb_rk3568/MAINTAINERS > +++ b/board/rockchip/evb_rk3568/MAINTAINERS > @@ -89,3 +89,9 @@ M: Maxim Moskalets <[email protected]> > S: Maintained > F: arch/arm/dts/rk3566-rock-3c-u-boot.dtsi > F: configs/rock-3c-rk3566_defconfig > + > +LCKFB-TaishanPi > +M: Jiehui He <[email protected]> > +S: Maintained > +F: configs/lckfb-tspi-rk3566_defconfig > +F: arch/arm/dts/rk3566-lckfb-tspi-u-boot.dtsi > diff --git a/configs/lckfb-tspi-rk3566_defconfig > b/configs/lckfb-tspi-rk3566_defconfig > new file mode 100644 > index 00000000..126ede37 > --- /dev/null > +++ b/configs/lckfb-tspi-rk3566_defconfig > @@ -0,0 +1,84 @@ > +CONFIG_ARM=y > +CONFIG_SKIP_LOWLEVEL_INIT=y > +CONFIG_COUNTER_FREQUENCY=24000000 > +CONFIG_ARCH_ROCKCHIP=y > +CONFIG_SPL_GPIO=y
The SPL control FDT is not including any gpio related nodes, this could be dropped. > +CONFIG_DEFAULT_DEVICE_TREE="rockchip/rk3566-lckfb-tspi" > +CONFIG_ROCKCHIP_RK3568=y > +CONFIG_SPL_SERIAL=y > +CONFIG_SYS_LOAD_ADDR=0xc00800 > +CONFIG_DEBUG_UART_BASE=0xFE660000 > +CONFIG_DEBUG_UART_CLOCK=24000000 > +CONFIG_DEBUG_UART=y > +CONFIG_FIT=y > +CONFIG_FIT_VERBOSE=y > +CONFIG_SPL_FIT_SIGNATURE=y > +CONFIG_SPL_LOAD_FIT=y > +CONFIG_LEGACY_IMAGE_FORMAT=y > +CONFIG_DEFAULT_FDT_FILE="rockchip/rk3566-lckfb-tspi.dtb" > +# CONFIG_DISPLAY_CPUINFO is not set > +CONFIG_DISPLAY_BOARDINFO_LATE=y > +CONFIG_SPL_MAX_SIZE=0x40000 > +CONFIG_SPL_PAD_TO=0x7f8000 > +# CONFIG_SPL_RAW_IMAGE_SUPPORT is not set > +CONFIG_SPL_POWER=y The SPL control FDT is not including any power related nodes, this could be dropped. > +CONFIG_SPL_ATF=y > +CONFIG_CMD_GPIO=y > +CONFIG_CMD_GPT=y > +CONFIG_CMD_I2C=y > +CONFIG_CMD_MMC=y > +CONFIG_CMD_USB=y > +CONFIG_CMD_ROCKUSB=y > +CONFIG_CMD_USB_MASS_STORAGE=y > +# CONFIG_CMD_SETEXPR is not set > +CONFIG_CMD_PMIC=y > +CONFIG_CMD_REGULATOR=y > +# CONFIG_SPL_DOS_PARTITION is not set > +CONFIG_SPL_OF_CONTROL=y > +CONFIG_OF_LIVE=y > +CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks > assigned-clock-rates assigned-clock-parents" > +CONFIG_SYS_RELOC_GD_ENV_ADDR=y > +CONFIG_SPL_DM_SEQ_ALIAS=y > +CONFIG_SPL_REGMAP=y > +CONFIG_SPL_SYSCON=y > +CONFIG_SPL_CLK=y > +# CONFIG_USB_FUNCTION_FASTBOOT is not set > +CONFIG_ROCKCHIP_GPIO=y > +CONFIG_SYS_I2C_ROCKCHIP=y > +CONFIG_LED=y > +CONFIG_LED_GPIO=y > +CONFIG_MISC=y > +CONFIG_SUPPORT_EMMC_RPMB=y > +CONFIG_MMC_DW=y > +CONFIG_MMC_DW_ROCKCHIP=y > +CONFIG_MMC_SDHCI=y > +CONFIG_MMC_SDHCI_SDMA=y > +CONFIG_MMC_SDHCI_ROCKCHIP=y > +CONFIG_DWC_ETH_QOS=y > +CONFIG_DWC_ETH_QOS_ROCKCHIP=y It does not look like the device tree enable any Ethernet devices, these two could be dropped. > +CONFIG_PHY_ROCKCHIP_INNO_USB2=y > +CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y > +CONFIG_SPL_PINCTRL=y > +CONFIG_DM_PMIC=y > +CONFIG_DM_PMIC_FAN53555=y > +CONFIG_PMIC_RK8XX=y > +CONFIG_SPL_DM_REGULATOR=y > +CONFIG_SPL_DM_REGULATOR_FIXED=y The SPL control FDT is not including any fixed regulators, these two could be dropped. > +CONFIG_REGULATOR_RK8XX=y > +CONFIG_SPL_RAM=y > +CONFIG_BAUDRATE=1500000 > +CONFIG_DEBUG_UART_SHIFT=2 > +CONFIG_SYS_NS16550_MEM32=y > +CONFIG_SYSRESET=y > +CONFIG_SYSRESET_PSCI=y > +CONFIG_USB=y > +CONFIG_USB_XHCI_HCD=y > +CONFIG_USB_XHCI_GENERIC=y > +CONFIG_USB_EHCI_HCD=y > +CONFIG_USB_EHCI_GENERIC=y > +CONFIG_USB_DWC3=y > +CONFIG_USB_DWC3_GENERIC=y > +CONFIG_USB_GADGET=y > +CONFIG_USB_GADGET_DOWNLOAD=y > +CONFIG_USB_FUNCTION_ROCKUSB=y > +CONFIG_ERRNO_STR=y > diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst > index 1407080f..ae9a8c8a 100644 > --- a/doc/board/rockchip/rockchip.rst > +++ b/doc/board/rockchip/rockchip.rst > @@ -112,6 +112,7 @@ List of mainline supported Rockchip boards: > - Radxa ROCK 3C (rock-3c-rk3566) > - Radxa ZERO 3W/3E (radxa-zero-3-rk3566) > - Xunlong Orange Pi 3B (orangepi-3b-rk3566) > + - LCKFB TaishanPi (lckfb-tspi-rk3566) Please add this line in correct alphabetical order and not at the bottom. Regards, Jonas > > * rk3568 > - Rockchip Evb-RK3568 (evb-rk3568)
