Re: [PATCH 04/11] rockchip: Ensure device settings is defined before rk3568_common.h

[Kever Yang]

On 2025/4/6 08:24, Jonas Karlman wrote:

Ensure ROCKCHIP_DEVICE_SETTINGS is defined before including
rk3568_common.h in board include/configs files.

Signed-off-by: Jonas Karlman <jo...@kwiboo.se>

Reviewed-by: Kever Yang <kever.y...@rock-chips.com>

Thanks,
- Kever

---
  include/configs/anbernic-rgxx3-rk3566.h | 4 ++--
  include/configs/evb_rk3568.h            | 4 ++--
  include/configs/powkiddy-x55-rk3566.h   | 4 ++--
  3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/include/configs/anbernic-rgxx3-rk3566.h 
b/include/configs/anbernic-rgxx3-rk3566.h
index 3c4ea4e7d843..3d9e05a976a5 100644
--- a/include/configs/anbernic-rgxx3-rk3566.h
+++ b/include/configs/anbernic-rgxx3-rk3566.h
@@ -3,10 +3,10 @@
  #ifndef __ANBERNIC_RGXX3_RK3566_H
  #define __ANBERNIC_RGXX3_RK3566_H

-#include <configs/rk3568_common.h>

-
  #define ROCKCHIP_DEVICE_SETTINGS \
                        "stdout=serial,vidconsole\0" \
                        "stderr=serial,vidconsole\0"

+#include <configs/rk3568_common.h>

+
  #endif
diff --git a/include/configs/evb_rk3568.h b/include/configs/evb_rk3568.h
index a0f2383bf2f2..9070160cf58d 100644
--- a/include/configs/evb_rk3568.h
+++ b/include/configs/evb_rk3568.h
@@ -6,10 +6,10 @@
  #ifndef __EVB_RK3568_H
  #define __EVB_RK3568_H

-#include <configs/rk3568_common.h>

-
  #define ROCKCHIP_DEVICE_SETTINGS \
                        "stdout=serial,vidconsole\0" \
                        "stderr=serial,vidconsole\0"

+#include <configs/rk3568_common.h>

+
  #endif
diff --git a/include/configs/powkiddy-x55-rk3566.h 
b/include/configs/powkiddy-x55-rk3566.h
index 4b25c6a87740..8ace435434fc 100644
--- a/include/configs/powkiddy-x55-rk3566.h
+++ b/include/configs/powkiddy-x55-rk3566.h
@@ -3,10 +3,10 @@
  #ifndef __POWKIDDY_X55_RK3566_H
  #define __POWKIDDY_X55_RK3566_H

-#include <configs/rk3568_common.h>

-
  #define ROCKCHIP_DEVICE_SETTINGS \
                        "stdout=serial,vidconsole\0" \
                        "stderr=serial,vidconsole\0"

+#include <configs/rk3568_common.h>

+
  #endif