On Thu, 10 Apr 2025 09:04:35 +0200 Jernej Škrabec <[email protected]> wrote:
> Dne sreda, 9. april 2025 ob 02:20:29 Srednjeevropski poletni čas je Andre > Przywara napisal(a): > > From: Samuel Holland <[email protected]> > > > > AXP PMICs have a pin which can either report the USB VBUS state, or > > driving a regulator that supplies USB VBUS. Add a regulator driver for > > controlling this pin. The selection between input and output is done via > > the x-powers,drive-vbus-en pin on the PMIC (parent) node. > > > > Signed-off-by: Samuel Holland <[email protected]> > > Signed-off-by: Andre Przywara <[email protected]> > > Would it be less error prone to auto enable Kconfig option when compatible > AXP device is enabled? That way defconfigs could be smaller. Driver is pretty > small anyway. Yes, but the whole PMIC config is quite a mess at the moment. Those AXPxxx_POWER symbols are really for the SPL part only, and do nothing in U-Boot proper, where everything is guarded by CONFIG_REGULATOR_AXP and properly detected at runtime through the DT. I tried to enable this driver for all 64-bit boards, to be able to drop the TF-A code, but ran into problems with the H616 RSB boards, because of this overlap and this "PMIC bus" feature. So I have patches to enable this more universally, and will look at this in the next days and weeks, but first wanted to get the non-controversial parts in, like the driver itself. > In any case: > Reviewed-by: Jernej Skrabec <[email protected]> Many thanks for that! Cheers, Andre > > Best regards, > Jernej > >
