Hi Casey,
On Fri, Apr 11, 2025 at 02:47:45PM +0200, Caleb Connolly wrote:
> There are 134 pins not 133, oops! This fixes the sdcard on the RB1 as
> the pins now all get configured correctly.
>
> Fixes: 0ecb8cfcb930 ("pinctrl: qcom: add qcm2290 pinctrl driver")
> Reviewed-by: Sumit Garg <[email protected]>
> Reviewed-by: Neil Armstrong <[email protected]>
> Tested-by: Sumit Garg <[email protected]>
> Signed-off-by: Caleb Connolly <[email protected]>
> ---
> drivers/pinctrl/qcom/pinctrl-qcm2290.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
I think this is an independent fix for SD card to work on RB1. Can you
queue it for v2025.07?
Also, I am not sure if you are planning this complete series for
v2025.07. If not then can we atleast have a DT override for USB DR mode
to make it work on RB1 in v2025.07?
-Sumit
> diff --git a/drivers/pinctrl/qcom/pinctrl-qcm2290.c
> b/drivers/pinctrl/qcom/pinctrl-qcm2290.c
> index
> 0c2222ce663e6d584d229e7521f88fedf8aa19da..84f76b63b93ad78182524661dba561672feb4c85
> 100644
> --- a/drivers/pinctrl/qcom/pinctrl-qcm2290.c
> +++ b/drivers/pinctrl/qcom/pinctrl-qcm2290.c
> @@ -44,9 +44,9 @@ static int qcm2290_get_function_mux(__maybe_unused unsigned
> int pin, unsigned in
> }
>
> struct msm_pinctrl_data qcm2290_data = {
> .pin_data = {
> - .pin_count = 133,
> + .pin_count = 134,
> .special_pins_start = 127,
> },
> .functions_count = ARRAY_SIZE(msm_pinctrl_functions),
> .get_function_name = qcm2290_get_function_name,
>
> --
> 2.49.0
>
