On Wednesday, June 15, 2011 17:37:33 Ilya Yanok wrote: > Sometimes we want to build common tools without configuring for specific > target. Currently top Makefile has some support for this but it doesn't > work. This patch tries to fix this.
i think you'll need to split this up in logical sep changesets since you are fixing different problems. > Things changed: > - config.mk disable 'ld script not found error' in case if we are > building tools only. i dont like copying & pasting the same logic in multiple places. this is how code rots and bug fixes diverge. considering LDSCRIPT/CONFIG_SYS_LDSCRIPT only get used by the top level u-boot file, and only when the system is configured, i wonder if we shouldnt just rip it out of config.mk and into the top level Makefile. let's see what Scott thinks ... > - Makefile mkimage relies on autogenerated version so we need to > move $(VERSION_FILE) rule out of ifeq and make tools rule depend on it. the VERSION_FILE changes look fine > - tools/Makefile put common/env_embedded.o and envcrc.o to object list > conditionally. This fixes errors during dependency generation. pretty sure this breaks board builds. if the only thing this fixes is a harmless warning when generating dependency files, then i say ignore it. after all, this is how it has always worked in the past and no one really cared. -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
