On Mon, Aug 18 2025, Tom Rini <tr...@konsulko.com> wrote:
> At this time there are still major Linux distributions which by default
> boot using LEGACY_IMAGE_FORMAT type scripts. Add this option to
> DISTRO_DEFAULTS to ensure these platforms can still boot.
>
> Fixes: d780965927d4 ("Drop the special am335x_boneblack_vboot target")
> Reported-by: Sascha Silbe <sascha-...@silbe.org>
> Signed-off-by: Tom Rini <tr...@konsulko.com>
> ---
> boot/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/boot/Kconfig b/boot/Kconfig
> index 2ff6f0037384..a6fc46ff4f5f 100644
> --- a/boot/Kconfig
> +++ b/boot/Kconfig
> @@ -1163,6 +1163,7 @@ config DISTRO_DEFAULTS
> select CMD_SYSBOOT
> select HUSH_PARSER
> select SYS_LONGHELP
> + select LEGACY_IMAGE_FORMAT
> help
No objections, but I wonder if this, and all the others, would be better
of being "imply" instead of "select". After all, DISTRO_DEFAULTS is
mostly a convenience symbol that turns on other commonly needed/useful symbols,
not something that is absolute required when turning on some
"DISTRO_DEFAULTS feature".
That would allow a defconfig file to set DISTRO_DEFAULTS, but still
explicitly disable things like LEGACY_IMAGE_FORMAT. And it's actually
somewhat hard to migrate away from having that set if it's select'ed by
DISTRO_DEFAULTS - one would have to deselect that, but then manually
ensure that all the previously select'ed items were set explicitly.
Rasmus
