Hi Jonas,

> I cannot find any rockchip board in U-Boot or Linux that currently use
> a ethernet2 alias, have you sent a Linux patch that I have missed?
>
> The addition of eth1addr was done because there are and was in-tree
> boards that have use for both ethaddr and eth1addr.
>
> Suggest you send a Linux patch that adds or updates a rockchip dts to
> include an ethernet2 alias before this is applied.

sorry I missed your message that time. I thought about the chicken&egg issue with the aliases being defined in Linux and used in U-Boot, and chose to offer the patch for U-Boot first, since the aliases can be defined in Linux via device tree overlays, without touching sources and recompiling the kernel.

I will offer a patch to Linux then, hope the reaction is not similar there like "why should we define aliases which are not used by anything?" :)

Maybe this is the common order, and certainly has the benefit that you can sync the aliases back into U-Boot device trees, so those benefit from the same static MAC addresses, in case they are really applied to U-Boot device tree aliases as well.

I'll keep you updated regarding Linux patch.

Best regards,
Micha

Attachment: OpenPGP_0x0442B9ADE65643FE.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to