On Sun, Sep 21, 2025 at 09:15:43AM -0300, Fabio Estevam wrote:
> Hi Alice,
> 
> On Thu, Sep 11, 2025 at 3:42 AM Alice Guo (OSS) <[email protected]> wrote:
> 
> > > >  #include 
> > > > "../../../../../dts/upstream/src/arm64/freescale/imx95-clock.h"
> > >
> > > What is this? I asked and it was suggested to send a patch upstream, but 
> > > they
> > > said no. Ref:
> ...
> > This line of code is unnecessary and can be deleted.
> 
> > > Again this weird include relative-global path... not good.
> > >
> > > I don't know what it should be, sorry. It is fragile and we should do 
> > > something
> > > better.
> > >
> >
> > These files are derived from the Linux source code.
> 
> Please address E Shattow's comments and send a v2 that also contains
> the imx94-evk support.
> 
> This way, we can achieve build coverage for the entire series.

There was some discussion of this on IRC as well, and the issue is that
(for now?) this header in the kernel is supposed to be with the dts
files and not dt-bindings and so it's not in a normal search path.

I think that for us that means we should do some Makefile games in that
directory and add a -I$(srctree)/dts/... and comment in the code to say
this is a DT header file.

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to