On 06/10/2025 16:38, Quentin Schulz wrote:
Hi Andrew, Tom,
On 10/1/25 11:28 AM, Andrew Goodbody wrote:
The recent change to .b4-config resulted in some expected recipients not
being added to the address lists. Rework the commands so that all
expected recipients are added while maintaining the ordering from the
first change.
Fixes: 26efc940c86 ("b4-config: configure `b4` for U-Boot")
Signed-off-by: Andrew Goodbody <[email protected]>
---
.b4-config | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/.b4-config b/.b4-config
index
6ba10cf9b50e6acb8a789544d35a13641e6c0411..1f9ada793e652c99854e4d15241734c9b3bfc117 100644
--- a/.b4-config
+++ b/.b4-config
@@ -2,6 +2,5 @@
# See https://b4.docs.kernel.org/en/latest/config.html
[b4]
- send-series-to = [email protected]
- send-auto-to-cmd = echo ""
- send-auto-cc-cmd = scripts/get_maintainer.pl
+ send-auto-to-cmd = scripts/get_maintainer.pl --nogit --nogit-
fallback --nogit-chief-penguins --norolestats --nom
+ send-auto-cc-cmd = scripts/get_maintainer.pl --nogit-fallback --
nogit-chief-penguins --norolestats --nol
This seems to differ with b4 defaults[1] by swapping --nom and --nol
between to and cc recipients. Is this expected?
Hi Quentin,
Yes this is expected and intended. Please see the discussion here
https://lore.kernel.org/u-boot/20250929160453.GI6093@bill-the-cat/T/#m3d26d2ca4c42d620260fedaeca5f869a41fe26e5
where the original patch
http://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
attempted to bring the use of b4 into line with U-Boot commit guidelines
by putting the U-Boot list in To: and maintainers in Cc:.
In the meantime I was getting complaints that my patches were not
including recent committers in the Cc: list and that patch did not
address this although at one point I thought it would.
So the current settings now put the list into To: and also add recent
committers into the Cc: list.
I am not sure where the expectation to Cc: recent committers comes from
apart from the fact that when you run get_maintainer.pl on the command
line, then they are listed there.
Andrew
I've been using b4 for years in U-Boot without a .b4-config so I'm
curious why we suddenly have a need for one and I think it'd make sense
to document that (now as a comment in .b4-config since this patch has
been merged already).
Cheers,
Quentin
[1] https://b4.docs.kernel.org/en/latest/config.html#contributor-
oriented-settings
