On 25/09/2025 15:12, Marek Vasut wrote:
On 9/25/25 4:07 PM, Andrew Goodbody wrote:
On 25/09/2025 14:56, Marek Vasut wrote:
On 9/25/25 3:20 PM, Andrew Goodbody wrote:
In dwc3_ep0_complete_data there is a test for 'r' being null and the
code will return at that point if so. After that point 'r' is
guaranteed
to not be null and testing for that is redundant. Remove the test for
'r' being non-null.
This issue was found by Smatch.
Signed-off-by: Andrew Goodbody <[email protected]>
---
drivers/usb/dwc3/ep0.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c
index c656cbe25ce..680756532f0 100644
--- a/drivers/usb/dwc3/ep0.c
+++ b/drivers/usb/dwc3/ep0.c
@@ -799,10 +799,7 @@ static void dwc3_ep0_complete_data(struct dwc3
*dwc,
status = DWC3_TRB_SIZE_TRBSTS(trb->size);
if (status == DWC3_TRBSTS_SETUP_PENDING) {
dev_dbg(dwc->dev, "Setup Pending received");
-
- if (r)
- dwc3_gadget_giveback(ep0, r, -ECONNRESET);
-
+ dwc3_gadget_giveback(ep0, r, -ECONNRESET);
return;
}
Please use ./scripts/get_maintainer.pl to get full CC list and CC all
relevant parties.
Hi Marek,
I use 'b4 prep --auto-to-cc' which calls get_maintainer.pl to populate
the email addresses used.
It seems to be missing these people:
Mattijs Korpershoek <[email protected]>
Neil Armstrong <[email protected]>
Anshul Dalal <[email protected]>
So it looks like the default command used by b4 for the Cc: section is
"scripts/get_maintainer.pl --nogit --nogit-fallback
--nogit-chief-penguins --norolestats --nom" which causes recent signers
to not be included due to the '--nogit' argument.
I have added the following to my git config file.
[b4]
send-auto-cc-cmd = scripts/get_maintainer.pl --nogit-fallback
--nogit-chief-penguins --norolestats --nom
This will mean that from now on recent signers will be added to the Cc:
list. I hope that this is what is expected.
I will resend this patch with the expanded Cc: list.
Andrew
