Hi Tom, On Thu, 9 Oct 2025 at 18:35, Tom Rini <[email protected]> wrote: > > On Thu, Oct 09, 2025 at 03:29:55AM -0600, Simon Glass wrote: > > > The code at the end of iter_inc() is already somewhat tortuous. Before > > making it worse, move it into a function. > > This is not a great commit message. Taking a look at v2 as a whole, the > reason to extract this logic from the end of iter_inc is because you > will be checking it in multiple places. That is a good reason to move > the code. Adding another 5 lines of code (a single if test) alone would > not be.
OK, so how about: The code at the end of iter_inc() is already somewhat tortuous. A future series needs to call it in from two places in iter_inc(), so move it into a function. Regards, Simon
