On Thu Oct 9, 2025 at 9:09 AM UTC, Yao Zi wrote: > On Wed, Oct 08, 2025 at 10:00:38AM +0000, Ferass El Hafidi wrote: >> Add a minimal non-DM MMC driver for use in size-constrained >> environments. >> >> Signed-off-by: Ferass El Hafidi <[email protected]> >> --- >> arch/arm/include/asm/arch-meson/gx.h | 5 +++ >> drivers/mmc/meson_gx_mmc.c | 75 >> +++++++++++++++++++++++++++++++++++- >> 2 files changed, 79 insertions(+), 1 deletion(-) >> >> --- a/drivers/mmc/meson_gx_mmc.c >> +++ b/drivers/mmc/meson_gx_mmc.c > > ... > >> +#if !CONFIG_IS_ENABLED(DM_MMC) > > This is a large conditional compilation block with nested #if's, do you > think commenting #else and #endif with the condition improves the > readibility? i.e. > > #if !CONFIG_IS_ENABLED(DM_MMC) > > ... > > #else /* !CONFIG_IS_ENALBED(DM_MMC) */ > > ... > > #endif /* CONFIG_IS_ENALBED(DM_MMC) */ >
Sounds good to me, thanks for the suggestion. Best regards, Ferass
